plat/common: remove fall-through on release build
authorJonathan Wright <[email protected]>
Wed, 14 Mar 2018 17:55:32 +0000 (17:55 +0000)
committerJonathan Wright <[email protected]>
Mon, 26 Mar 2018 11:43:05 +0000 (12:43 +0100)
Removes fall-through in switch statement on unknown interrupt type in
release builds.

Previous behaviour was to assert(0) on default case in debug builds but
fall through and interpret the unknown interrupt type as
INTR_TYPE_EL3 in release builds.

Change-Id: I05fb0299608efda0f9eda2288d3e56e5625e05c9
Signed-off-by: Jonathan Wright <[email protected]>
plat/common/plat_gicv3.c

index 030eea723cc29d57b534f181515477eea9c51b6d..cf9aca229ff5413974ad7ccffa25b3c8aeee7187 100644 (file)
@@ -158,15 +158,14 @@ uint32_t plat_interrupt_type_to_line(uint32_t type,
                        return __builtin_ctz(SCR_FIQ_BIT);
                else
                        return __builtin_ctz(SCR_IRQ_BIT);
-       default:
-               assert(0);
-               /* Fall through in the release build */
        case INTR_TYPE_EL3:
                /*
                 * The EL3 interrupts are signaled as FIQ in both S-EL0/1 and
                 * NS-EL0/1/2 contexts
                 */
                return __builtin_ctz(SCR_FIQ_BIT);
+       default:
+               panic();
        }
 }